Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sunburst Rotation #5171

Merged
merged 8 commits into from
Oct 8, 2020
Merged

sunburst Rotation #5171

merged 8 commits into from
Oct 8, 2020

Conversation

thierryVergult
Copy link
Contributor

Reuse rotation attribute from Pie

feature: see> Sunburst Rotation (Starting point) #4728

@archmoj archmoj added status: in progress community community contribution feature something new labels Sep 28, 2020
@archmoj
Copy link
Contributor

archmoj commented Sep 28, 2020

Thanks very much for the PR.

@thierryVergult
sunburst rotation - attribute
b889c94 
Redefine attribute rotation (from @archmoj  ; 2af75a8).

Not from pie anymore.

The extra angle is *counterclockwise*
@alexcjohnson
Copy link
Collaborator

@thierryVergult this is a nice feature! In addition to the above comments, let's just take one of the existing sunburst mocks and add a rotation to it, then update the baseline image. That should suffice for testing the rotation.

@thierryVergult
sunburst rotation
f90737b 
Bringing in suggestions from @alexcjohnson
@archmoj
Copy link
Contributor

archmoj commented Oct 8, 2020

💃

@archmoj archmoj merged commit dadcd06 into plotly:master Oct 8, 2020
@thierryVergult thierryVergult deleted the sunburstRotation branch October 8, 2020 15:12
@archmoj archmoj mentioned this pull request Oct 8, 2020
Merged
@archmoj archmoj added this to the v1.57.0 milestone Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcjohnson alexcjohnson alexcjohnson left review comments

@archmoj archmoj archmoj left review comments

Assignees
No one assigned
Labels
community community contribution feature something new
Projects
None yet
Milestone
v1.57.0
Development

Successfully merging this pull request may close these issues.
3 participants
@thierryVergult @archmoj @alexcjohnson